Fic loc paths from projects for localization and remove res swix#63
Fic loc paths from projects for localization and remove res swix#63
Conversation
…ogleTest into dev/spebl/swixloc
|
Note: The 4 strings in GoogleTestAdapter.Common.Dynamic.dll aren't currently being localized and will still always appear in english. Working on fixing that now but wanted to get the main chunk in. This has to do with the way we load the DLL in Common. |
| <BypassVsixValidation>true</BypassVsixValidation> | ||
| <DeployExtension Condition="'$(TestAdapterFlavor)' != 'TAfGT'">false</DeployExtension> | ||
| <IsProductComponent>true</IsProductComponent> | ||
| <IsProductComponent>$(IsProductComponent)</IsProductComponent> |
There was a problem hiding this comment.
Wouldn't it be more canonical to do Condition and set true/false accordingly?
There was a problem hiding this comment.
This is interesting since it's using the replacement from Microbuild for this actually. I do agree we should set it default here in case this isn't set (for local build for instance).
| @@ -1,42 +0,0 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
We don't need these files any more? Because we now set IsProductComponent?
There was a problem hiding this comment.
They were never used actually. I had them there since I was basing the loc after a different example which ended up being unnecessary.
2 participants
Also added option to specify if it's a product component for vs installer and added mission dlls to setversion.ps1